windowmaker-wl

Commit Graph

Author	SHA1	Message	Date
Levi Neely	36aa1c5725	wayland: Phase 69 — WIN_WORKSPACE macro; safe workspace reads without frame Add WIN_WORKSPACE(w) macro to window.h that returns frame->workspace when the window has a frame (X11 path) or wwin->workspace when it does not (Wayland path, set in Phase 67). Replace all unsafe frame->workspace reads with WIN_WORKSPACE() in: - window.c: wWindowObscuresWindow (workspace comparison + geometry), wWindowFocusPrev/Next (same-workspace filter), wWindowSaveState (state serialization) - session.c: session save (workspace name lookup) - switchmenu.c: all five switch-menu workspace comparisons/lookups Also guard wWindowObscuresWindow's frame->core width/height reads with a ternary that falls back to client.{width,height} for frameless windows. This eliminates the last class of NULL frame->workspace dereferences reachable from workspace-switch, focus-cycle, session-save, and switch-menu code paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-28 09:43:09 +01:00
Levi Neely	a486329b52	Wayland backend abstraction: WMBackend vtable (Phases 0–30) Introduce a display-system-agnostic WMBackend vtable that routes all display operations through function pointers, making the WM policy layer independent of X11. The X11 implementation is preserved in src/backend/x11/ and behaviour is unchanged. Key structural changes ────────────────────── • src/backend/backend_types.h — backend-neutral type definitions: WNativeWindow, WKeyCode, WContextKey, WBackendScreen, WBackendEvent (+typed fields), WNormalHints, WWMHints, WNETWindowType, WHeadGeometry, WClientAttributes, WClientVisual, WSegment, WPoint, WM_KEY_* keysym constants, WA_* atom IDs, WKB_GROUP_INDEX, WCUR_NONE • src/backend/backend.h — WMBackend vtable (~100 function-pointer slots) covering: frame/context lifecycle, stacking, focus, grabs, pointer, keyboard, overlays, properties, ICCCM, EWMH/NETWM, monitors, screen setup, cursors, extensions, error handlers. No <X11/> headers remain in this file after Phase 30. • src/backend/x11/ — X11 backend implementation: x11_backend.c full vtable; all display calls confined here x11_props.c WM_NORMAL_HINTS / WM_HINTS translation x11_event.c XEvent → WBackendEvent translation x11_monitor.c Xinerama / RandR monitor query Policy files cleaned ──────────────────── All 47 files in WM_POLICY_CLEAN_FILES pass check-no-x11-policy (no direct #include <X11/> anywhere). X11 types that still appear in policy structs (Visual, Colormap, Window, Atom …) arrive only transitively via WINGs.h; the vtable boundary itself is X11-free. Tests ───── • tests/smoke-test.sh — full Xvfb lifecycle test (PASS) • tests/test_geom.c — geometry / constraint unit tests • tests/test_x11_event.c — WBackendEvent field extraction tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-27 19:20:00 +01:00
Levi Neely	fcee811b99	WindowMaker 0.96.0 upstream source	2026-03-26 15:38:49 +01:00

Author

SHA1

Message

Date

Levi Neely

36aa1c5725

wayland: Phase 69 — WIN_WORKSPACE macro; safe workspace reads without frame

Add WIN_WORKSPACE(w) macro to window.h that returns frame->workspace
when the window has a frame (X11 path) or wwin->workspace when it does
not (Wayland path, set in Phase 67).

Replace all unsafe frame->workspace reads with WIN_WORKSPACE() in:
  - window.c:   wWindowObscuresWindow (workspace comparison + geometry),
                wWindowFocusPrev/Next (same-workspace filter),
                wWindowSaveState (state serialization)
  - session.c:  session save (workspace name lookup)
  - switchmenu.c: all five switch-menu workspace comparisons/lookups

Also guard wWindowObscuresWindow's frame->core width/height reads with
a ternary that falls back to client.{width,height} for frameless windows.

This eliminates the last class of NULL frame->workspace dereferences
reachable from workspace-switch, focus-cycle, session-save, and
switch-menu code paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-03-28 09:43:09 +01:00

Levi Neely

a486329b52

Wayland backend abstraction: WMBackend vtable (Phases 0–30)

Introduce a display-system-agnostic WMBackend vtable that routes all
display operations through function pointers, making the WM policy
layer independent of X11.  The X11 implementation is preserved in
src/backend/x11/ and behaviour is unchanged.

Key structural changes
──────────────────────
• src/backend/backend_types.h — backend-neutral type definitions:
    WNativeWindow, WKeyCode, WContextKey, WBackendScreen,
    WBackendEvent (+typed fields), WNormalHints, WWMHints,
    WNETWindowType, WHeadGeometry, WClientAttributes, WClientVisual,
    WSegment, WPoint, WM_KEY_* keysym constants, WA_* atom IDs,
    WKB_GROUP*_INDEX, WCUR_NONE

• src/backend/backend.h — WMBackend vtable (~100 function-pointer
    slots) covering: frame/context lifecycle, stacking, focus, grabs,
    pointer, keyboard, overlays, properties, ICCCM, EWMH/NETWM,
    monitors, screen setup, cursors, extensions, error handlers.
    No <X11/> headers remain in this file after Phase 30.

• src/backend/x11/ — X11 backend implementation:
    x11_backend.c  full vtable; all display calls confined here
    x11_props.c    WM_NORMAL_HINTS / WM_HINTS translation
    x11_event.c    XEvent → WBackendEvent translation
    x11_monitor.c  Xinerama / RandR monitor query

Policy files cleaned
────────────────────
All 47 files in WM_POLICY_CLEAN_FILES pass check-no-x11-policy
(no direct #include <X11/> anywhere).  X11 types that still appear
in policy structs (Visual*, Colormap, Window, Atom …) arrive only
transitively via WINGs.h; the vtable boundary itself is X11-free.

Tests
─────
• tests/smoke-test.sh — full Xvfb lifecycle test (PASS)
• tests/test_geom.c   — geometry / constraint unit tests
• tests/test_x11_event.c — WBackendEvent field extraction tests

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-03-27 19:20:00 +01:00

Levi Neely

fcee811b99

WindowMaker 0.96.0 upstream source

2026-03-26 15:38:49 +01:00

3 Commits