lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Replace sprintf with snprintf in ptools.c 

Prevents buffer overflow if paramname is longer than 254 bytes.
charBuff[i] is 258 bytes, sprintf(charBuff[i], "key%s", paramname)
can overflow.

Fixes #217
This commit is contained in:
Levi Neely 2026-03-03 15:18:06 +01:00
parent 465d5b9fb6
commit 7ef4417694
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pclsync/ptools.c
View File

@ -139,7 +139,7 @@ int ptools_create_backend_event(const char *binapi, const char *category,
strcat(keyParams, params->Params[i].paramname);
}
sprintf(charBuff[i], "key%s", params->Params[i].paramname);
snprintf(charBuff[i], sizeof(charBuff[i]), "key%s", params->Params[i].paramname);
if (params->Params[i].paramtype == 0) {
paramsLocal[mpCnt + i] =