From 7ef44176946bcef87f3ad064f51543b80776044b Mon Sep 17 00:00:00 2001 From: Levi Neely Date: Tue, 3 Mar 2026 15:18:06 +0100 Subject: [PATCH] Replace sprintf with snprintf in ptools.c Prevents buffer overflow if paramname is longer than 254 bytes. charBuff[i] is 258 bytes, sprintf(charBuff[i], "key%s", paramname) can overflow. Fixes #217 --- pclsync/ptools.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pclsync/ptools.c b/pclsync/ptools.c index f48ba82..51c67d7 100644 --- a/pclsync/ptools.c +++ b/pclsync/ptools.c @@ -139,7 +139,7 @@ int ptools_create_backend_event(const char *binapi, const char *category, strcat(keyParams, params->Params[i].paramname); } - sprintf(charBuff[i], "key%s", params->Params[i].paramname); + snprintf(charBuff[i], sizeof(charBuff[i]), "key%s", params->Params[i].paramname); if (params->Params[i].paramtype == 0) { paramsLocal[mpCnt + i] =