lkn
/
kate-deft
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

radial: fix Ollie plugin lookup key (ollie_kate, not ollie-kate) 

pluginView() is keyed by the plugin's catalog name (the .so / target name),
not its KPlugin metadata Id. Ollie's own code confirms the convention —
pluginView("kateprojectplugin"), pluginView("gitplusplus"). The Ollie Kate
plugin's target is ollie_kate, so the key is "ollie_kate" (underscore), not the
metadata Id "ollie-kate" (hyphen). With the wrong key pluginView returned null
and the Ollie radial branch never appeared.
This commit is contained in:
Levi Neely 2026-10-09 10:58:12 +02:00
parent 629a2da68d
commit f05ad9b654
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/radial/radialplugin.cpp
View File

@ -214,7 +214,7 @@ RadialNode RadialView::ollieBranchIfActive() const
// findActionByName; instead we invoke the plugin view's Q_INVOKABLE action
// methods by name in onRadialActivated. Each slice carries an "ollie:" id.
RadialNode branch;
if (!m_mainWindow->pluginView(QStringLiteral("ollie-kate"))) {
if (!m_mainWindow->pluginView(QStringLiteral("ollie_kate"))) {
return branch; // not enabled -> empty, caller omits it
}
@ -248,7 +248,7 @@ bool RadialView::triggerOllieVerb(const QString &actionId) const
if (!actionId.startsWith(QLatin1String("ollie:"))) {
return false;
}
QObject *view = m_mainWindow->pluginView(QStringLiteral("ollie-kate"));
QObject *view = m_mainWindow->pluginView(QStringLiteral("ollie_kate"));
if (!view) {
return true; // recognised as ours, but nothing to invoke
}