From f05ad9b654f37e7bd749eed0779f0337a40f85f2 Mon Sep 17 00:00:00 2001 From: Levi Neely Date: Fri, 9 Oct 2026 10:58:12 +0200 Subject: [PATCH] radial: fix Ollie plugin lookup key (ollie_kate, not ollie-kate) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pluginView() is keyed by the plugin's catalog name (the .so / target name), not its KPlugin metadata Id. Ollie's own code confirms the convention — pluginView("kateprojectplugin"), pluginView("gitplusplus"). The Ollie Kate plugin's target is ollie_kate, so the key is "ollie_kate" (underscore), not the metadata Id "ollie-kate" (hyphen). With the wrong key pluginView returned null and the Ollie radial branch never appeared. --- src/radial/radialplugin.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/radial/radialplugin.cpp b/src/radial/radialplugin.cpp index b8f689d..2bca716 100644 --- a/src/radial/radialplugin.cpp +++ b/src/radial/radialplugin.cpp @@ -214,7 +214,7 @@ RadialNode RadialView::ollieBranchIfActive() const // findActionByName; instead we invoke the plugin view's Q_INVOKABLE action // methods by name in onRadialActivated. Each slice carries an "ollie:" id. RadialNode branch; - if (!m_mainWindow->pluginView(QStringLiteral("ollie-kate"))) { + if (!m_mainWindow->pluginView(QStringLiteral("ollie_kate"))) { return branch; // not enabled -> empty, caller omits it } @@ -248,7 +248,7 @@ bool RadialView::triggerOllieVerb(const QString &actionId) const if (!actionId.startsWith(QLatin1String("ollie:"))) { return false; } - QObject *view = m_mainWindow->pluginView(QStringLiteral("ollie-kate")); + QObject *view = m_mainWindow->pluginView(QStringLiteral("ollie_kate")); if (!view) { return true; // recognised as ours, but nothing to invoke }