lkn
/
windowmaker-wl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

WINGs/wayland: use backing image dimensions for fill_rectangles 

The fill_rectangles call used view->size which can exceed the backing
image dimensions when a view is resized during realization without its
backing being reallocated. This wrote past the allocated buffer,
corrupting the heap and causing later pixman_image_composite32 crashes.
Use pixman_image_get_width/height of the actual backing instead.
This commit is contained in:
Window Maker 2026-05-25 13:22:41 +02:00
parent 7a93b1d389
commit 6e18e1fe0d
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
WINGs/wview_wl.c
View File

@ -442,19 +442,20 @@ static void wl_redisplay(void *vctx, W_View *view)
/* Fill background color */
pixman_image_t *backing = (pixman_image_t *)W_GetViewBacking(view->window);
if (backing && view->backColor) {
if (backing) {
int bw = pixman_image_get_width(backing);
int bh = pixman_image_get_height(backing);
pixman_color_t bg;
bg.red = view->backColor->color.red;
bg.green = view->backColor->color.green;
bg.blue = view->backColor->color.blue;
bg.alpha = view->backColor->alpha ? view->backColor->alpha : 0xFFFF;
if (view->backColor) {
bg.red = view->backColor->color.red;
bg.green = view->backColor->color.green;
bg.blue = view->backColor->color.blue;
bg.alpha = view->backColor->alpha ? view->backColor->alpha : 0xFFFF;
} else {
bg = (pixman_color_t){0xAAAA, 0xAAAA, 0xAAAA, 0xFFFF};
}
pixman_image_fill_rectangles(PIXMAN_OP_SRC, backing, &bg,
1, &(pixman_rectangle16_t){0, 0, view->size.width, view->size.height});
} else if (backing) {
/* Default: light grey background */
pixman_color_t bg = {0xAAAA, 0xAAAA, 0xAAAA, 0xFFFF};
pixman_image_fill_rectangles(PIXMAN_OP_SRC, backing, &bg,
1, &(pixman_rectangle16_t){0, 0, view->size.width, view->size.height});
1, &(pixman_rectangle16_t){0, 0, bw, bh});
}
memset(&ev, 0, sizeof(ev));