lkn
/
windowmaker-wl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wire W_ViewSceneNodeSetEnabledFn in WINGs client path via recycle/remap 

In WINGs client mode (e.g. WPrefs), W_ViewSceneNodeSetEnabledFn was never
set because the compositor-side wl_backend.c does not run in the client
process. When popup close calls wl_unmap, the function pointer was NULL,
so the scene node was never disabled and the popup remained visible.

Fix: during W_WLClientInit, if W_ViewSceneNodeSetEnabledFn is still NULL
(unset by compositor), set it to wl_client_scene_node_set_enabled which
calls recycle (destroy xdg_toplevel + wl_surface) on disable and remap
(recreate from scratch) on enable. This ensures the client-side popup
lifecycle correctly removes and recreates the surface, eliminating stale
pixels without depending on compositor-side function pointers.
This commit is contained in:
lkn 2026-06-07 15:44:22 +02:00
parent 405c481e38
commit 340a60927e
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
WINGs/wclient_wl.c
View File

@ -645,6 +645,15 @@ wl_client_toplevel_remap(WNativeWindow id)
wl_client_toplevel_remap_locked(top);
}
void
wl_client_scene_node_set_enabled(unsigned long id, int enabled)
{
if (enabled)
wl_client_toplevel_remap((WNativeWindow)id);
else
wl_client_toplevel_recycle((WNativeWindow)id);
}
void
W_WLClientSetMinMaxSize(W_View *view)
{
@ -1388,6 +1397,17 @@ W_WLClientInit(struct W_Screen *scrPtr, const char *display)
W_WLClientToplevelRealizeFn = wl_client_toplevel_realize;
W_WLClientToplevelResizeFn = wl_client_toplevel_resize;
W_WLClientToplevelDestroyFn = wl_client_toplevel_destroy;
/* Wire up scene-node enable/disable for client toplevels.
* When running as a client (e.g. WPrefs), the compositor-side
* function pointer is not available, so we use recycle/remap
* to destroy/recreate the wl_surface instead. */
extern void (*W_ViewSceneNodeSetEnabledFn)(unsigned long id, int enabled);
if (!W_ViewSceneNodeSetEnabledFn) {
extern void wl_client_toplevel_recycle(WNativeWindow);
extern void wl_client_toplevel_remap(WNativeWindow);
W_ViewSceneNodeSetEnabledFn =
wl_client_scene_node_set_enabled;
}
{
extern void (*W_ViewCommitBackingFn)(unsigned long id);
extern void (*W_ViewDestroyBackingFn)(unsigned long id);