From 1954fa2a12c1530becf629835e920e9c8b4cebe7 Mon Sep 17 00:00:00 2001 From: Window Maker Date: Mon, 25 May 2026 13:37:32 +0200 Subject: [PATCH] WINGs: fix WME_CLIENT_MESSAGE mask so close events reach handlers The wmeMaskForType table had WME_CLIENT_MESSAGE mapped to 0, so WMHandleEvent never dispatched client messages to registered handlers. The window close handler (registered with ClientMessageMask) was never called. Set the correct mask so the deleteWindow protocol works. --- WINGs/wevent.c | 2 +- wprefs.log | 33 +++------------------------------ 2 files changed, 4 insertions(+), 31 deletions(-) diff --git a/WINGs/wevent.c b/WINGs/wevent.c index 716f3fa..3c8deba 100644 --- a/WINGs/wevent.c +++ b/WINGs/wevent.c @@ -40,7 +40,7 @@ static const unsigned long wmeventMasks[] = { [WME_SELECTION] = 0, [WME_SELECTION_REQUEST] = 0, [WME_SELECTION_CLEAR] = 0, - [WME_CLIENT_MESSAGE] = 0, + [WME_CLIENT_MESSAGE] = ClientMessageMask, [WME_COLORMAP] = WM_EVMASK_COLORMAP_CHANGE, [WME_VISIBILITY] = WM_EVMASK_VISIBILITY_CHANGE, [WME_MAPPING] = 0, diff --git a/wprefs.log b/wprefs.log index 1c49b11..b7e618b 100644 --- a/wprefs.log +++ b/wprefs.log @@ -1,31 +1,4 @@ +; WPrefs Fontconfig warning: using without calling FcInit() -WPrefs(registry_handle_global(wclient_wl.c:1130)): warning: wclient_wl: bound wmaker_popup_manager_v1 - -=== WPrefs CRASH === -signal 11 -WPrefs(+0xe13a) [0x55555556213a] -/usr/lib64/libc.so.6(+0x3d520) [0x7ffff732e520] -/usr/lib64/libpixman-1.so.0(+0x4780d) [0x7ffff7a0380d] -/usr/lib64/libpixman-1.so.0(pixman_image_composite32+0x41) [0x7ffff79c2a81] -/usr/local/lib/libWINGs.so.3(+0x34844) [0x7ffff7f79844] -/usr/local/lib/libWINGs.so.3(+0x2d26c) [0x7ffff7f7226c] -/usr/local/lib/libWINGs.so.3(+0x2d39d) [0x7ffff7f7239d] -/usr/local/lib/libWINGs.so.3(WMHandleEvent+0x132) [0x7ffff7f6ac92] -/usr/local/lib/libWINGs.so.3(+0x45b4a) [0x7ffff7f8ab4a] -/usr/local/lib/libWINGs.so.3(+0x45b71) [0x7ffff7f8ab71] -/usr/local/lib/libWINGs.so.3(+0x45b71) [0x7ffff7f8ab71] -/usr/local/lib/libWINGs.so.3(+0x45b71) [0x7ffff7f8ab71] -/usr/local/lib/libWINGs.so.3(+0x45b71) [0x7ffff7f8ab71] -/usr/local/lib/libWINGs.so.3(+0x45b71) [0x7ffff7f8ab71] -/usr/local/lib/libWINGs.so.3(W_MapView+0x36) [0x7ffff7f89926] -/usr/local/lib/libWINGs.so.3(W_RealizeView+0xd8) [0x7ffff7f89a38] -/usr/local/lib/libWINGs.so.3(W_RealizeView+0x77) [0x7ffff7f899d7] -/usr/local/lib/libWINGs.so.3(W_RealizeView+0x77) [0x7ffff7f899d7] -/usr/local/lib/libWINGs.so.3(W_RealizeView+0x77) [0x7ffff7f899d7] -WPrefs(+0x188c8) [0x55555556c8c8] -WPrefs(+0xe2e6) [0x5555555622e6] -/usr/local/lib/libWINGs.so.3(WMHandleEvent+0x132) [0x7ffff7f6ac92] -WPrefs(+0xdf36) [0x555555561f36] -/usr/lib64/libc.so.6(+0x273fb) [0x7ffff73183fb] -/usr/lib64/libc.so.6(__libc_start_main+0x8b) [0x7ffff73184ab] -WPrefs(+0xe015) [0x555555562015] +WPrefs(registry_handle_global(wclient_wl.c:1132)): warning: wclient_wl: bound wmaker_popup_manager_v1 +WPrefs(xdg_toplevel_handle_close(wclient_wl.c:368)): warning: wclient_wl: xdg_toplevel_handle_close fired for view=0x20000001