Fixes recommended by maintainer.
1. Buffer Overflow in FUSE Options Parsing (pfs.c)
- Fixed
2. Base64 Padding Bug (putil.c)
- I believe the padding logic at lines 273-284 is not a bug - it's correct per RFC 4648 base64 specification. Padding is only added when length != 0
(i.e., when there's a partial final block), and the correct number of "=" characters are added based on whether 1 or 2 bytes remain.
3. Memory Leaks in pdiff.c
- Fixed
4. Race Condition in Log Rotation (pdbg.c)
- I believe the code is actually already correct.
- The code at line 20 already uses volatile sig_atomic_t:
static volatile sig_atomic_t log_reopen_requested = 0;
This is the correct and safe pattern for signal handler communication:
1. sig_atomic_t - Guarantees atomic read/write operations (no partial updates)
2. volatile - Prevents the compiler from optimizing away accesses
The pattern is correct:
- Signal handler (pdbg_reopen_log at line 178-180) only sets the flag - async-signal-safe
- Main code checks/resets the flag inside pthread_mutex_lock() (lines 133-136, 231-234)
- Actual log reopening (do_reopen_log) happens in the main thread, not signal context
This is a well-established and safe pattern. The mutex ensures the check-and-reset is serialized with other logging, and sig_atomic_t
ensures the signal-to-main-thread communication is atomic.
5. Hardcoded RSA Padding (pssl.c)
- Fixed
6. Unchecked Exception (pclsync_lib.cpp)
- Fixed
7. Missing Input Validation
- Fixed
Issue #1: Double Logging and Memory Leak in `process_deletefile()`
- Fixed duplicate log.
- Note: There was no actual memory leak - the first path allocation at line 1731 was properly freed at line 1735 before the second
allocation at line 1739.
Issue #2: FUSE Options Parsing Problems
- Fixed
- DoD 5220.22-M compliant memory wipe replaces single-pass zero wipe
- Wipe in-memory request and response messages before freeing
- Wipe in-memory private keys and salt data before freeing
- Wipe all passwords on unlink / logout
- Wipe crypto password on all pcryptofolder_unlock return paths
* support non-interactive command processing
- app is now configured in setup_app function
- added process_command() to api
- support piped input and -c argument
- fix memleaks
* list_sync_folders seems to work
* list_sync_folders breaks with sync folders in db; message size problem?
* fixed sync folders list
* fix double free and buffer overflow
* wip: add and remove sync folder; need to fix request->value in instance_thread
* remove comment
* removed pclsync_lib_c.{h,cpp}
* cleanup get_answer_to_request
* update comment
* changed reply struct to type response containing payload and msg
* cleanup
* refactored overlay_client, and poverlay; added docs
* better naming
* sock path in poverlay_protocol.h
* clarify comment
* refactor psync_overlay_get_response
* clarifications
* response_messages work with and without payload
* removed commented code
* syncadd works, but i need to fix the error handling
* remove sync folder
* remove commented code, change printfs to debug or simply remove
* removed unnecessary print
* removed more prints
* removed dead var
* update error handling in add_sync_folder, fix memleak
* simplified finalize
* openssl is a dependency
* openssl is not a real dpendency
* static link by default
* wip: build containers
* rm comments
* build containers, fix DEADLYSIGNAL on run with no args
* debug tools in deb/ubuntu, fix#44
* no slack container :(
* ensure P_LINUX_OS always defined
* error check fuse unmount ops
* fsanitize=thread temporarily
* undo
* clang static analysis
* fix dead assignment
* makefile quality of life stuff
* make install and uninstall; ignore scan results
* addressed dead assignments from static analysis
* debug and release builds possible
* gcc still default compiler
* debug symbols on debug build only
* reorg source tree, link system mbedtls
* remove cmakelists.txt
* update ci workflow
* -Werror to -Wall
* libpcloudcc_so in makefile
* single makefile works
* removed extra makefiles
Jonathan Senkerik
Levi Neely
FloFri