lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak in pfs_update_openfile on collision (#327) 

File operations tested, no regression
This commit is contained in:
Levi Neely 2026-03-03 16:10:18 +01:00 committed by GitHub
parent 07cbef9b88
commit cb938aa128
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
pclsync/pfs.c
View File

@ -220,11 +220,34 @@ int pfs_update_openfile(uint64_t taskid, uint64_t writeid,
else
break;
} else {
pdbg_logf(D_BUG, "found already open file %lu, should not happen",
pdbg_logf(D_BUG, "found already open file %lu, re-inserting old fileid",
(unsigned long)newfileid);
break;
tr = openfiles;
d = -1;
while (tr) {
d = fileid - ptree_element(tr, psync_openfile_t, tree)->fileid;
if (d < 0) {
if (tr->left)
tr = tr->left;
else
break;
} else if (d > 0) {
if (tr->right)
tr = tr->right;
else
break;
} else
break;
}
if (d < 0)
ptree_add_before(&openfiles, tr, &fl->tree);
else
ptree_add_after(&openfiles, tr, &fl->tree);
ret = -1;
goto unlock_ret;
}
}
fl->fileid = newfileid;
if (d < 0)
ptree_add_before(&openfiles, tr, &fl->tree);
else
@ -243,6 +266,7 @@ int pfs_update_openfile(uint64_t taskid, uint64_t writeid,
}
ret = -1;
}
unlock_ret:
pthread_mutex_unlock(&fl->mutex);
psql_unlock();
return ret;