lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix pthread_create return unchecked in prun.c (#300) 

pthread_create() return value is ignored. If it fails, the allocated
thread_data is leaked.

Check return value; on error, log and free the data.

Fixes GH #221

Co-authored-by: Levi Neely <lkn@darkstar.example.net>
This commit is contained in:
Levi Neely 2026-03-03 12:16:30 +01:00 committed by GitHub
parent beaa76adfb
commit b902d47706
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pclsync/prun.c
View File

@ -3,6 +3,7 @@
#include "psettings.h"
#include "prun.h"
#include "pdbg.h"
// required by thread_entry
extern PSYNC_THREAD const char *psync_thread_name;
@ -32,6 +33,7 @@ static void start_thread(const char *name, void *run, void *ptr) {
thread_data *data;
pthread_t thread;
pthread_attr_t attr;
int ret;
data = malloc(sizeof(thread_data));
data->run = run;
@ -41,8 +43,13 @@ static void start_thread(const char *name, void *run, void *ptr) {
pthread_attr_init(&attr);
pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED);
pthread_attr_setstacksize(&attr, PSYNC_STACK_SIZE);
pthread_create(&thread, &attr, thread_entry, data);
ret = pthread_create(&thread, &attr, thread_entry, data);
pthread_attr_destroy(&attr);
if (ret) {
pdbg_logf(D_ERROR, "pthread_create failed for thread %s: %d", name, ret);
free(data);
}
}
void prun_thread(const char *name, thread0_run run) {