From 9541ea1f1e94abdabe03f24add8d0aeb305d02b8 Mon Sep 17 00:00:00 2001 From: Levi Neely <141506390+lneely@users.noreply.github.com> Date: Sat, 29 Jun 2024 14:13:00 +0200 Subject: [PATCH] don't publish crypto password to logs in plain text --- lib/pclsync/poverlay.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/lib/pclsync/poverlay.c b/lib/pclsync/poverlay.c index 5b4e6a2..a37d0c8 100644 --- a/lib/pclsync/poverlay.c +++ b/lib/pclsync/poverlay.c @@ -86,7 +86,15 @@ void get_answer_to_request(message *request, message *reply) psync_path_status_t stat=PSYNC_PATH_STATUS_NOT_OURS; memcpy(reply->value, "Ok.", 4); reply->length=sizeof(message)+4; - debug(D_NOTICE, "Client Request type [%u] len [%lu] string: [%s]", request->type, request->length, request->value); + + if(request->type == 20 /* STARTCRYPTO, see control_tools.cpp */) { + // don't publish the crypto password to the logs in plain text... + debug(D_NOTICE, "Client Request type [%u] len [%lu] string: [%s]", request->type, request->length, "REDACTED"); + } else { + debug(D_NOTICE, "Client Request type [%u] len [%lu] string: [%s]", request->type, request->length, request->value); + } + + if (request->type < 20 ) { if (overlays_running) stat=psync_path_status_get(request->value);