lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix char[] passed as char** in ptools_set_backend_file_dates (#305) 

msgErr was declared as char[1024] but cast to char** and passed to
ptools_backend_call(). The function writes a char* into *err,
corrupting the first sizeof(char*) bytes of the array.

Change to char *errPtr = NULL and free it after use.

Fixes GH #216

Co-authored-by: Levi Neely <lkn@darkstar.example.net>
This commit is contained in:
Levi Neely 2026-03-03 12:34:18 +01:00 committed by GitHub
parent 3c096565ea
commit 838b826b90
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
pclsync/ptools.c
View File

@ -451,7 +451,7 @@ void ptools_send_psyncs_event(const char *binapi, const char *auth) {
int ptools_set_backend_file_dates(uint64_t fileid, time_t ctime, time_t mtime) {
int callRes;
char msgErr[1024];
char *errPtr = NULL;
binresult *retData;
pdbg_logf(D_NOTICE,
@ -469,7 +469,7 @@ int ptools_set_backend_file_dates(uint64_t fileid, time_t ctime, time_t mtime) {
callRes =
ptools_backend_call(apiserver, "setfilemtime", FOLDER_META, &requiredParams1,
&optionalParams, &retData, (char **)msgErr);
&optionalParams, &retData, &errPtr);
pdbg_logf(D_NOTICE, "cTime res: [%d]", callRes);
@ -481,10 +481,13 @@ int ptools_set_backend_file_dates(uint64_t fileid, time_t ctime, time_t mtime) {
callRes =
ptools_backend_call(apiserver, "setfilemtime", FOLDER_META, &requiredParams,
&optionalParams, &retData, (char **)msgErr);
&optionalParams, &retData, &errPtr);
pdbg_logf(D_NOTICE, "mTime res: [%d]", callRes);
if (errPtr)
free(errPtr);
return callRes;
}