lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix pcl-3la: pstatus saturating add and fuse thread cleanup (#352) 

* Fix pcl-3la.1: saturating addition for bytestou in pstatus_upload_recalc

Replace unchecked uint64_t summation in pstatus_upload_recalc() with
overflow-safe saturating addition. Before adding each file's size,
check if the result would wrap around UINT64_MAX; if so, saturate to
UINT64_MAX instead of silently wrapping.

Ref GH #293.

* Fix pcl-3la.2: remove spurious fuse_loop_mt while-loop and exit(0)

fuse_loop_mt() already loops internally; wrapping it in an additional
while loop caused repeated re-entry after normal exit. Also removes
the exit(0) call in the shutdown path so fuse_destroy() and other
cleanup run properly on shutdown.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Levi Neely <lkn@darkstar.example.net>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Levi Neely 2026-03-07 16:24:53 +01:00 committed by GitHub
parent 7a8aef3b50
commit 5a519ab675
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pclsync/pfs.c
View File

@ -3651,21 +3651,13 @@ static void psync_fuse_thread() {
}
pthread_mutex_unlock(&start_mutex);
pdbg_logf(D_NOTICE, "running fuse_loop_mt");
// Check shutdown flag periodically during FUSE loop
while (!shutdown_requested) {
fr = fuse_loop_mt(psync_fuse);
if (fr != 0 || shutdown_requested) {
break;
}
}
fr = fuse_loop_mt(psync_fuse);
if (shutdown_requested) {
pdbg_logf(D_NOTICE, "shutdown requested, exiting fuse loop");
pfs_do_stop();
exit(0);
}
pdbg_logf(D_NOTICE, "fuse_loop_mt exited with code %d, running fuse_destroy", fr);
pthread_mutex_lock(&start_mutex);
fuse_destroy(psync_fuse);

6
pclsync/pstatus.c
View File

@ -222,7 +222,11 @@ void pstatus_upload_recalc() {
putil_strcat(fscpath, "/", fileidhex, NULL);
if (!stat(filename, &st)) {
filestou++;
bytestou += pfile_stat_size(&st);
uint64_t fsize = pfile_stat_size(&st);
if (fsize > UINT64_MAX - bytestou)
bytestou = UINT64_MAX;
else
bytestou += fsize;
}
free(filename);
}