lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix integer overflow in fake fileid calculation 

Replace INT64_MAX - (UINT64_MAX - taskid) with INT64_MIN + taskid.
Avoids signed/unsigned mixing and signed overflow (UB).

Fixes #252
This commit is contained in:
Levi Neely 2026-03-03 15:53:07 +01:00
parent a5b09c73c6
commit 2ed0dc3432
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pclsync/pfs.c
View File

@ -1389,8 +1389,10 @@ static int pfs_open(const char *path, struct fuse_file_info *fi) {
} else { /* cr->fileid==0 */
psync_fstask_local_creat_t *lc;
int64_t fake_fileid;
lc = pfs_task_creat_get_local(cr);
of = pfs_create_file(INT64_MAX - (UINT64_MAX - cr->taskid), 0,
fake_fileid = INT64_MIN + (int64_t)cr->taskid;
of = pfs_create_file(fake_fileid, 0,
lc->datalen, 0, 1, 0,
pfs_task_get_ref_locked(folder),
fpath->name, PSYNC_CRYPTO_INVALID_ENCODER);