lkn
/
pcloudcc-lneely
mirror of https://github.com/lneely/pcloudcc-lneely.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix NULL-deref in pfs_rename_openfile_locked 

Check putil_strdup return before freeing old name.
On OOM, keep old name and return -ENOMEM instead of setting NULL.

Fixes #260
This commit is contained in:
Levi Neely 2026-03-03 15:55:52 +01:00
parent 6ce166a0a5
commit 138e73e254
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pclsync/pfs.c
View File

@ -309,8 +309,13 @@ int pfs_rename_openfile_locked(psync_fsfileid_t fileid,
fl->currentfolder = fl->currentfolder =
pfs_task_get_or_create_folder_tasks_locked(folderid); pfs_task_get_or_create_folder_tasks_locked(folderid);
} }
char *newname = putil_strdup(name);
if (!newname) {
pthread_mutex_unlock(&fl->mutex);
return -ENOMEM;
}
free(fl->currentname); free(fl->currentname);
fl->currentname = putil_strdup(name); fl->currentname = newname;
pthread_mutex_unlock(&fl->mutex); pthread_mutex_unlock(&fl->mutex);
return 1; return 1;
} }