2b59409845
refactor: remove dead code across packages (-220 lines)
...
Dead code removal based on code review:
fs/spec.go:
- Remove unused Perm* constant aliases
fs/support.go:
- Remove unused agentCwd() function
session/registry.go:
- Remove unused CreateAgent() (callers use CreateAgentWithParams directly)
session/session.go:
- Remove unused sweepStaleTmpDirs() and sweepTmpOnce
- Remove unused Session.LoadTool() (callers use LoadToolOnConn directly)
- Simplify Resume() by removing dead else branch (Pause() always nils Keeper)
toolsrv/server/proc.go:
- Remove unused globalProcCounter
- Remove unused ListProcsWithState()
toolsrv/server/server.go:
- Remove unused Mode* constants
toolsrv/bypass/bypass.go:
- Remove unused PendingCount()
toolsrv/sandbox/config.go:
- Remove unused checkPath() and pathUnder()
backend/new.go:
- Remove unused newBackend() (callers use NewWithName)
agent/loop.go:
- Remove unused contextBudget()
agent/agent.go + turn.go + runtime.go:
- Remove unused startupMessages, StartupMsgs, Runtime.Messages
agent/agent_config.go:
- Remove unused Tools *bool field and ToolsEnabled() (tools always enabled)
2026-08-21 16:41:42 +02:00
1fc051e3bf
refactor: move olliesrv and toolsrv packages to cmd/*/internal/
...
Move server-only packages under their respective cmd directories:
olliesrv:
- agent/ -> cmd/olliesrv/internal/agent/
- backend/ -> cmd/olliesrv/internal/backend/
- bypass/ -> cmd/olliesrv/internal/bypass/
- fs/ -> cmd/olliesrv/internal/fs/
- prompts/ -> cmd/olliesrv/internal/prompts/
- session/ -> cmd/olliesrv/internal/session/
toolsrv:
- Server-only code (exec9p, fs9p, server9p, spec9p, auth9p) -> cmd/toolsrv/
- sandbox/ -> cmd/toolsrv/internal/sandbox/
- Keep shared client code (client9p, spawn, registry, meta) in toolsrv/
- Add toolsrv/types.go for shared types (ToolResult, ToolResultContent)
This enforces package boundaries - code in cmd/*/internal/ cannot be
imported by external packages, while shared code remains importable.
2026-08-10 20:16:44 +02:00
Levi Neely
Ollie Agent