From a7b8c4c2ce4ad533c3f10ebf2af999ca536392a7 Mon Sep 17 00:00:00 2001
From: Levi Neely <lneely@pascom.net>
Date: Wed, 19 Aug 2026 18:09:09 +0200
Subject: [PATCH] Add 'none' workflow option as the default (no-op on goal set)

- Workflow() no longer defaults to 'conductor' when empty
- runWorkflow() returns immediately for '' or 'none'
- 'none' listed first in the workflows file output
- QML dropdowns default to 'none' instead of 'conductor'
- C++ fallback uses 'none' when server unreachable
---
 cmd/olliesrv/internal/fs/spec.go         | 6 ++++++
 cmd/olliesrv/internal/session/session.go | 5 +----
 kde/gui/NewSessionDialog.qml             | 6 +++---
 kde/gui/ollie9pclient.cpp                | 4 ++--
 4 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/cmd/olliesrv/internal/fs/spec.go b/cmd/olliesrv/internal/fs/spec.go
index 3f46605..a60c824 100644
--- a/cmd/olliesrv/internal/fs/spec.go
+++ b/cmd/olliesrv/internal/fs/spec.go
@@ -63,7 +63,11 @@ func startAsync(ctx context.Context, fn func()) bool {
 // runWorkflow executes a workflow script in the background.
 // If variant is non-empty and not "default", the matching conf sidecar is
 // sourced as environment variables before the script runs.
+// If workflow is empty or "none", nothing happens.
 func runWorkflow(s *session.Session, workflow, variant string) {
+	if workflow == "" || workflow == "none" {
+		return
+	}
 	startAsync(s.Ctx, func() {
 		workflowDir := util.CfgDir() + "/workflows/"
 		scriptPath := workflowDir + workflow
@@ -205,6 +209,8 @@ func buildTreeSpec(cfg *Config) virtfs.FsNodeDecl {
 					}
 				}
 				var sb strings.Builder
+				// "none" is always the first entry — it means no workflow runs.
+				sb.WriteString("none\tdefault\n")
 				names := make([]string, 0, len(workflows))
 				for wf := range workflows {
 					names = append(names, wf)
diff --git a/cmd/olliesrv/internal/session/session.go b/cmd/olliesrv/internal/session/session.go
index 34da95c..b6ce164 100644
--- a/cmd/olliesrv/internal/session/session.go
+++ b/cmd/olliesrv/internal/session/session.go
@@ -257,14 +257,11 @@ func (s *Session) GoalSignal() <-chan struct{} {
 	return ch
 }
 
-// Workflow returns the workflow profile name (default: "conductor").
+// Workflow returns the workflow profile name (default: "none").
 func (s *Session) Workflow() string {
 	s.mu.RLock()
 	w := s.workflow
 	s.mu.RUnlock()
-	if w == "" {
-		return "conductor"
-	}
 	return w
 }
 
diff --git a/kde/gui/NewSessionDialog.qml b/kde/gui/NewSessionDialog.qml
index be86680..e006f13 100644
--- a/kde/gui/NewSessionDialog.qml
+++ b/kde/gui/NewSessionDialog.qml
@@ -135,7 +135,7 @@ Dialog {
                 enabled: ollie.workflowsLoaded
                 model: ollie.availableWorkflows
                 currentIndex: {
-                    var idx = ollie.availableWorkflows.indexOf("conductor")
+                    var idx = ollie.availableWorkflows.indexOf("none")
                     return idx >= 0 ? idx : 0
                 }
                 onCurrentTextChanged: {
@@ -242,7 +242,7 @@ Dialog {
             cwdField.text = cfg.cwd || ""
             remoteField.text = cfg.remote || ""
 
-            var wfIdx = ollie.availableWorkflows.indexOf(cfg.workflow || "conductor")
+            var wfIdx = ollie.availableWorkflows.indexOf(cfg.workflow || "none")
             workflowCombo.currentIndex = wfIdx >= 0 ? wfIdx : 0
 
             // Populate variant after workflow is set.
@@ -261,7 +261,7 @@ Dialog {
             cwdField.text = ""
             remoteField.text = ""
             yoloCheckBox.checked = false
-            var idx = ollie.availableWorkflows.indexOf("conductor")
+            var idx = ollie.availableWorkflows.indexOf("none")
             workflowCombo.currentIndex = idx >= 0 ? idx : 0
             variantCombo.currentIndex = 0
         }
diff --git a/kde/gui/ollie9pclient.cpp b/kde/gui/ollie9pclient.cpp
index 417db25..f73474c 100644
--- a/kde/gui/ollie9pclient.cpp
+++ b/kde/gui/ollie9pclient.cpp
@@ -602,8 +602,8 @@ void Ollie9pClient::loadWorkflows()
             }
         }
     } else {
-        m_availableWorkflows = QStringList() << QStringLiteral("conductor");
-        m_workflowVariants[QStringLiteral("conductor")] = QStringList() << QStringLiteral("default");
+        m_availableWorkflows = QStringList() << QStringLiteral("none");
+        m_workflowVariants[QStringLiteral("none")] = QStringList() << QStringLiteral("default");
     }
     m_workflowsLoaded = true;
     emit availableWorkflowsChanged();