From cbed4e1be8d2be42ce763594dcac267350f7199e Mon Sep 17 00:00:00 2001
From: Levi Neely <141506390+lneely@users.noreply.github.com>
Date: Mon, 6 Jul 2026 13:33:07 +0200
Subject: [PATCH] dolphin: split desktop file for KF5/KF6 authorization
 compatibility

KF6 enforces X-KDE-AuthorizeAction=shell_access strictly, causing
"not authorized" errors on context menu actions. The KF6 version
drops the authorize line (actions only invoke D-Bus helpers, not
raw shell). KF5 keeps it in a separate ollie-actions-kf5.desktop.
---
 Makefile                          |  9 ++++++---
 dolphin/ollie-actions-kf5.desktop | 16 ++++++++++++++++
 dolphin/ollie-actions.desktop     |  1 -
 3 files changed, 22 insertions(+), 4 deletions(-)
 create mode 100644 dolphin/ollie-actions-kf5.desktop

diff --git a/Makefile b/Makefile
index 61709b6..89bad97 100644
--- a/Makefile
+++ b/Makefile
@@ -70,7 +70,8 @@ install: daemon
 	kpackagetool6 -t Plasma/Applet -i plasmoid/
 	# Dolphin service menus + helper scripts
 	mkdir -p ~/.local/share/kio/servicemenus
-	install -m644 dolphin/ollie-actions.desktop ~/.local/share/kio/servicemenus/
+	rm -f ~/.local/share/kio/servicemenus/ollie-actions.desktop
+	install -m755 dolphin/ollie-actions.desktop ~/.local/share/kio/servicemenus/
 	sudo install -m755 dolphin/ollie-ask /usr/local/bin/
 	sudo install -m755 dolphin/ollie-session-here /usr/local/bin/
 	# XDG autostart
@@ -109,7 +110,8 @@ krunner-install: daemon
 
 dolphin-install:
 	mkdir -p ~/.local/share/kio/servicemenus
-	install -m644 dolphin/ollie-actions.desktop ~/.local/share/kio/servicemenus/
+	rm -f ~/.local/share/kio/servicemenus/ollie-actions.desktop
+	install -m755 dolphin/ollie-actions.desktop ~/.local/share/kio/servicemenus/
 	sudo install -m755 dolphin/ollie-ask /usr/local/bin/
 	sudo install -m755 dolphin/ollie-session-here /usr/local/bin/
 	@echo "Dolphin menus installed. Restart Dolphin or re-open context menu."
@@ -167,7 +169,8 @@ kf5-install: kf5
 	$(RM) -r /tmp/ollie-plasmoid-kf5
 	# Dolphin service menus + helper scripts
 	mkdir -p ~/.local/share/kio/servicemenus
-	install -m644 dolphin/ollie-actions.desktop ~/.local/share/kio/servicemenus/
+	rm -f ~/.local/share/kio/servicemenus/ollie-actions.desktop
+	install -m755 dolphin/ollie-actions-kf5.desktop ~/.local/share/kio/servicemenus/ollie-actions.desktop
 	sudo install -m755 dolphin/ollie-ask /usr/local/bin/
 	sudo install -m755 dolphin/ollie-session-here /usr/local/bin/
 	# XDG autostart
diff --git a/dolphin/ollie-actions-kf5.desktop b/dolphin/ollie-actions-kf5.desktop
new file mode 100644
index 0000000..db2e6be
--- /dev/null
+++ b/dolphin/ollie-actions-kf5.desktop
@@ -0,0 +1,16 @@
+[Desktop Entry]
+Type=Service
+X-KDE-ServiceTypes=KonqPopupMenu/Plugin
+MimeType=all/allfiles;inode/directory;
+Actions=askOllie;sessionHere;
+X-KDE-AuthorizeAction=shell_access
+
+[Desktop Action askOllie]
+Name=Ask Ollie about this
+Icon=system-run
+Exec=ollie-ask %f
+
+[Desktop Action sessionHere]
+Name=Start Ollie session here
+Icon=system-run
+Exec=ollie-session-here %f
diff --git a/dolphin/ollie-actions.desktop b/dolphin/ollie-actions.desktop
index db2e6be..6cee70c 100644
--- a/dolphin/ollie-actions.desktop
+++ b/dolphin/ollie-actions.desktop
@@ -1,6 +1,5 @@
 [Desktop Entry]
 Type=Service
-X-KDE-ServiceTypes=KonqPopupMenu/Plugin
 MimeType=all/allfiles;inode/directory;
 Actions=askOllie;sessionHere;
 X-KDE-AuthorizeAction=shell_access