From 62663aff4e6d3686b5c3548bddc4538e5ec9ab94 Mon Sep 17 00:00:00 2001 From: Levi Neely Date: Fri, 24 Jul 2026 11:58:09 +0200 Subject: [PATCH] add 6th arg (remote) to all CreateSession D-Bus calls --- dolphin/ollie-session-here | 2 +- kate/ollie_kate.cpp | 2 +- plasmoid/plugin/olliedbusclient.cpp | 2 +- test-e2e.sh | 2 +- test-peers.sh | 4 ++-- tray/ollie_tray.cpp | 2 +- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dolphin/ollie-session-here b/dolphin/ollie-session-here index e7f6949..d2792c3 100755 --- a/dolphin/ollie-session-here +++ b/dolphin/ollie-session-here @@ -8,7 +8,7 @@ TARGET="$(cd "$TARGET" 2>/dev/null && pwd)" || TARGET="$PWD" RESULT=$(dbus-send --session --dest=org.ollie.SessionManager --type=method_call --print-reply \ /org/ollie/SessionManager org.ollie.SessionManager.CreateSession \ - string:"$TARGET" string:"" string:"" string:"default" string:"" 2>&1) + string:"$TARGET" string:"" string:"" string:"default" string:"" string:"" 2>&1) SESSION_ID=$(echo "$RESULT" | grep 'string "' | head -1 | sed 's/.*string "\(.*\)"/\1/') diff --git a/kate/ollie_kate.cpp b/kate/ollie_kate.cpp index 1acb7d9..7d92b64 100644 --- a/kate/ollie_kate.cpp +++ b/kate/ollie_kate.cpp @@ -581,7 +581,7 @@ void OllieKateView::newSession() QString backend = m_plugin->defaultBackend(); QString model = m_plugin->defaultModel(); - QDBusReply reply = m_iface->call("CreateSession", cwd, backend, model, "default", QString()); + QDBusReply reply = m_iface->call("CreateSession", cwd, backend, model, "default", QString(), QString()); if (reply.isValid()) { m_sessionId = reply.value(); m_rawChat.clear(); diff --git a/plasmoid/plugin/olliedbusclient.cpp b/plasmoid/plugin/olliedbusclient.cpp index 44507bc..117e72b 100644 --- a/plasmoid/plugin/olliedbusclient.cpp +++ b/plasmoid/plugin/olliedbusclient.cpp @@ -271,7 +271,7 @@ QString OllieDBusClient::createSession(const QString &cwd, const QString &backen { QString dir = cwd.isEmpty() ? QDir::homePath() : cwd; auto *watcher = new QDBusPendingCallWatcher( - m_iface->asyncCall("CreateSession", dir, backend, model, QString("default"), QString()), + m_iface->asyncCall("CreateSession", dir, backend, model, QString("default"), QString(), QString()), this); connect(watcher, &QDBusPendingCallWatcher::finished, this, [this](QDBusPendingCallWatcher *w) { QDBusPendingReply reply = *w; diff --git a/test-e2e.sh b/test-e2e.sh index 39bc90b..3d4e339 100755 --- a/test-e2e.sh +++ b/test-e2e.sh @@ -23,7 +23,7 @@ echo "" echo "=== CreateSession ===" RESULT=$(dbus-send --session --dest=$SERVICE --type=method_call --print-reply \ $PATH_OBJ $IFACE.CreateSession \ - string:"$HOME" string:"" string:"" string:"default" string:"") + string:"$HOME" string:"" string:"" string:"default" string:"" string:"") echo "$RESULT" SESSION_ID=$(echo "$RESULT" | grep 'string "' | head -1 | sed 's/.*string "//;s/"//') echo "Session ID: $SESSION_ID" diff --git a/test-peers.sh b/test-peers.sh index d1572fa..81f770c 100755 --- a/test-peers.sh +++ b/test-peers.sh @@ -9,12 +9,12 @@ IFACE="org.ollie.SessionManager" echo "=== Create session A ===" A=$(dbus-send --session --dest=$SERVICE --type=method_call --print-reply \ - $OBJ $IFACE.CreateSession string:"$HOME" string:"" string:"" string:"default" string:"" | grep 'string "' | head -1 | sed 's/.*string "//;s/"//') + $OBJ $IFACE.CreateSession string:"$HOME" string:"" string:"" string:"default" string:"" string:"" | grep 'string "' | head -1 | sed 's/.*string "//;s/"//') echo "A: $A" echo "=== Create session B ===" B=$(dbus-send --session --dest=$SERVICE --type=method_call --print-reply \ - $OBJ $IFACE.CreateSession string:"$HOME" string:"" string:"" string:"default" string:"" | grep 'string "' | head -1 | sed 's/.*string "//;s/"//') + $OBJ $IFACE.CreateSession string:"$HOME" string:"" string:"" string:"default" string:"" string:"" | grep 'string "' | head -1 | sed 's/.*string "//;s/"//') echo "B: $B" echo "" diff --git a/tray/ollie_tray.cpp b/tray/ollie_tray.cpp index 75c2d8e..f4e766a 100644 --- a/tray/ollie_tray.cpp +++ b/tray/ollie_tray.cpp @@ -137,7 +137,7 @@ void OllieTray::onStateChanged(const QString &session_id, const QString &new_sta void OllieTray::newSession() { QString cwd = QDir::homePath(); - QDBusReply reply = m_iface->call("CreateSession", cwd, QString(), QString(), "default", QString()); + QDBusReply reply = m_iface->call("CreateSession", cwd, QString(), QString(), "default", QString(), QString()); if (reply.isValid()) { qDebug() << "Created session:" << reply.value(); } else {