From fb8f4acff16868493cabda7c5904c52b2c166cac Mon Sep 17 00:00:00 2001 From: Levi Neely Date: Mon, 27 Jul 2026 10:51:54 +0200 Subject: [PATCH] elevate: show key comment instead of fingerprint in notifications --- pkg/elevate/sshagent.go | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/pkg/elevate/sshagent.go b/pkg/elevate/sshagent.go index 01bc36b..8958ca3 100644 --- a/pkg/elevate/sshagent.go +++ b/pkg/elevate/sshagent.go @@ -121,6 +121,17 @@ func (a *approvalAgent) SignWithFlags(key ssh.PublicKey, data []byte, flags agen func (a *approvalAgent) signWithApproval(key ssh.PublicKey, data []byte, flags agent.SignatureFlags) (*ssh.Signature, error) { fp := ssh.FingerprintSHA256(key) + // Try to get key comment for readable display + comment := "" + if keys, err := a.upstream.List(); err == nil { + for _, k := range keys { + if ssh.FingerprintSHA256(k) == fp { + comment = k.Comment + break + } + } + } + // Check policy effective := a.broker.SessionPolicy("") if effective.Matches("", fp) { @@ -132,9 +143,14 @@ func (a *approvalAgent) signWithApproval(key ssh.PublicKey, data []byte, flags a } // Create pending request for approval + label := comment + if label == "" { + label = fp + } + req := &Request{ ID: nextRequestID(), - Cmd: fmt.Sprintf("ssh-sign: %s", fp), + Cmd: fmt.Sprintf("ssh-sign: %s", label), Cwd: "", SessionID: "", CreatedAt: timeNow(),